Set vm.max_map_count on systemd package install #21507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our docs claim that we set vm.max_map_count automatically. This is not quite the case. The story is that on SysV init we set vm.max_map_count each time the service starts, which is good. On systemd, we create a sysctl.d conf file that sets vm.map_max_count, but this is only meaningful if the system is rebooted after package install. This commit modifies the post-install script so that we run systemd-sysctl so that the vm.max_map_count change occurs after package install without a reboot.
jasontedor
added
:Delivery/Packaging
nik9000
approved these changes
Nov 11, 2016
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
Makes sense to me and it has a test. Perfect.
jasontedor
added a commit
that referenced
this pull request
Nov 11, 2016
Our docs claim that we set vm.max_map_count automatically. This is not quite the case. The story is that on SysV init we set vm.max_map_count each time the service starts, which is good. On systemd, we create a sysctl.d conf file that sets vm.map_max_count, but this is only meaningful if the system is rebooted after package install. This commit modifies the post-install script so that we run systemd-sysctl so that the vm.max_map_count change occurs after package install without a reboot. Relates #21507
jasontedor
added a commit
that referenced
this pull request
Nov 11, 2016
Our docs claim that we set vm.max_map_count automatically. This is not quite the case. The story is that on SysV init we set vm.max_map_count each time the service starts, which is good. On systemd, we create a sysctl.d conf file that sets vm.map_max_count, but this is only meaningful if the system is rebooted after package install. This commit modifies the post-install script so that we run systemd-sysctl so that the vm.max_map_count change occurs after package install without a reboot. Relates #21507
Member
Author
|
Thanks @nik9000. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our docs claim that we set vm.max_map_count automatically. This is not
quite the case. The story is that on SysV init we set vm.max_map_count
each time the service starts, which is good. On systemd, we create a
sysctl.d conf file that sets vm.map_max_count, but this is only
meaningful if the system is rebooted after package install. This commit
modifies the post-install script so that we run systemd-sysctl so that
the vm.max_map_count change occurs after package install without a
reboot.