Pass on maxUnsafeAutoIdTimestamp on recovery / relocation #20300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ensure we don't add documents more than once even if it's mostly paranoia except of one case where we relocated a shards away and back to the same node while an initial request is in flight but has not yet finished AND is retried. Yet, this is a possible case and for that reason we ensure we pass on the maxUnsafeAutoIdTimestamp on when we prepare for translog recovery.
s1monw
added
>enhancement
review
:Distributed Indexing/Recovery
| shards.flush(); | ||
| } | ||
| IndexShard replica = shards.addReplica(); | ||
| shards.recoverReplica(replica, (r, sourceNode) -> new RecoveryTarget(r, sourceNode, recoveryListener, version -> {})); |
Contributor
There was a problem hiding this comment.
we should probably add an overload for this.
Contributor
|
LGTM. PS. Relates to #20211 |
clintongormley
added
:Distributed Indexing/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure we don't add documents more than once even if it's mostly paranoia
except of one case where we relocated a shards away and back to the same node
while an initial request is in flight but has not yet finished AND is retried.
Yet, this is a possible case and for that reason we ensure we pass on the
maxUnsafeAutoIdTimestamp on when we prepare for translog recovery.