Skip smoke test client on JDK 9 #20260
Conversation
This commit adds an assumption to SmokeTestClientIT tests on JDK 9. The underlying issue is that Netty attempts to access sun.nio.ch but this package is not exported from java.base on JDK 9. This throws an uncaught InaccessibleObjectException causing the test to fail. This assumption can be removed when Netty 4.1.6 is released as it will include a fix for this scenario.
jasontedor
added
>test
| */ | ||
| public void testSimpleClient() { | ||
| // TODO: remove when Netty 4.1.5 is upgraded to Netty 4.1.6 including https://github.com/netty/netty/pull/5778 | ||
| assumeFalse("JDK is JDK 9", Constants.JRE_IS_MINIMUM_JAVA9); |
There was a problem hiding this comment.
Any way you can assert the netty version in here?
There was a problem hiding this comment.
@nik9000 I looked into it because we are accumulating a little bit of debt here to be paid when 4.1.6 is released. Here's the problem. This test uses a randomized client (sometimes it uses the mock transport plugin, sometimes Netty 4, and sometimes the default (Netty 4, this should be fixed so the randomization selects Netty 3). So, the first thing that would have to be done is expose which transport type the client is using. Then, we have to tear open the netty-common jar and read the jar manifest to parse out the netty-common.version. This seems like way more trouble than it's worth to me?
There was a problem hiding this comment.
this should be fixed so the randomization selects Netty 3
I opened #20265 for this point.
|
LGTM. Left a suggestion that you can ignore if you like. |
|
Thanks @nik9000! |
These tests were disabled due to an issue in Netty which has since been resolved and integrated into Elasticsearch. Relates #20260
These tests were disabled due to an issue in Netty which has since been resolved and integrated into Elasticsearch. Relates #20260
3 participants
This commit adds an assumption to SmokeTestClientIT tests on JDK 9. The
underlying issue is that Netty attempts to access sun.nio.ch but this
package is not exported from java.base on JDK 9. This throws an uncaught
InaccessibleObjectException causing the test to fail. This assumption
can be removed when Netty 4.1.6 is released as it will include a fix for
this scenario.
Relates #20251, netty/netty#5778