Update gateway.asciidoc #19572
Merged
Update gateway.asciidoc #19572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a note to clarify that, in cases where nodes in a cluster have different setting, the node that is the elected master takes precedence over anything else.
Contributor
|
I think we need to change the opening sentence too: It is not true (anymore?). It should read - the following static settings, which must be set on every master node... controls how long a freshly elected master should wait before it tries to recover the cluster state and the cluster's data. WDYT? |
Contributor
Author
|
That seems to be a much better way of describing it :) |
Contributor
|
@markwalkom you going to update your PR with the changes mentioned? |
Contributor
|
Also, I'd role the two |
Updated as per @bleskes's comments
Contributor
Author
|
Done, per @bleskes's comments. |
clintongormley
pushed a commit
that referenced
this pull request
Jul 28, 2016
* Update gateway.asciidoc Added a note to clarify that, in cases where nodes in a cluster have different setting, the node that is the elected master takes precedence over anything else. * Update gateway.asciidoc Updated as per @bleskes's comments
clintongormley
pushed a commit
that referenced
this pull request
Jul 28, 2016
* Update gateway.asciidoc Added a note to clarify that, in cases where nodes in a cluster have different setting, the node that is the elected master takes precedence over anything else. * Update gateway.asciidoc Updated as per @bleskes's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a note to clarify that, in cases where nodes in a cluster may have different settings, the settings on the node that is the elected master take precedence over anything else.