Use a static default precision for the cardinality aggregation. #19215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
force-pushed
the
enhancement/cardinality_static_default_precision
branch
from
2f364f9 to
cab49e5
Compare
Contributor
|
LGTM |
jpountz
force-pushed
the
enhancement/cardinality_static_default_precision
branch
from
cab49e5 to
ff155d3
Compare
…ic#19215 Today the default precision for the cardinality aggregation depends on how many parent bucket aggregations it had. The reasoning was that the more parent bucket aggregations, the more buckets the cardinality had to be computed on. And this number could be huge depending on what the parent aggregations actually are. However now that we run terms aggregations in breadth-first mode by default when there are sub aggregations, it is less likely that we have to run the cardinality aggregation on kagilions of buckets. So we could use a static default, which will be less confusing to users.
jpountz
force-pushed
the
enhancement/cardinality_static_default_precision
branch
from
ff155d3 to
bde99ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the default precision for the cardinality aggregation depends on how many
parent bucket aggregations it had. The reasoning was that the more parent bucket
aggregations, the more buckets the cardinality had to be computed on. And this
number could be huge depending on what the parent aggregations actually are.
However now that we run terms aggregations in breadth-first mode by default when
there are sub aggregations, it is less likely that we have to run the cardinality
aggregation on kagilions of buckets. So we could use a static default, which will
be less confusing to users.