fix explain in function_score if no function filter matches #19185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintongormley
added
the
:Search/Search
brwe
force-pushed
the
fix-func-score-explain
branch
from
ae07dfd to
854cc08
Compare
Member
There was a problem hiding this comment.
Nit: you could use Collections.emptyList() here.
Member
|
Left two very minor comments. Otherwise LGTM. |
When each function in function_score has a filter but none of them matches we always assume 1 for the combined functions and then combine that with the sub query score. But the explanation did not reflect that because in case no function matched we did not even use the actual score that was computed in the explanation.
brwe
force-pushed
the
fix-func-score-explain
branch
from
854cc08 to
3585673
Compare
Contributor
Author
|
@danielmitterdorfer thanks a lot for the review! addressed all comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When each function in function_score has a filter but none of them matches
we always assume 1 for the combined functions and then combine that with the
sub query score.
But the explanation did not reflect that because in case no function matched
we did not even use the actual score that was computed in the explanation.