Aggregations fix: support include/exclude strings for IP and dates #18408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markharwood
added
>bug
review
:Analytics/Aggregations
Contributor
|
Could you also test that regexp-based filtering on ips is not supported? I think |
…d date fields in terms and significant_terms aggregations. Closes elastic#17705
| if ((includeExclude != null) && (includeExclude.isRegexBased()) && format != DocValueFormat.RAW) { | ||
| throw new AggregationExecutionException("Aggregation [" + name + "] cannot support regular expression style include/exclude " | ||
| + "settings as they can only be applied to string fields. Use an array of values for include/exclude clauses"); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
@jpountz rather than adding a specialized test for IP field types I test for regex && format!=DocValueFormat.RAW && (valuesSource instanceof ValuesSource.Bytes)
Is this too broad?
Contributor
|
LGTM |
Contributor
Author
|
Pushed in a846ff9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added calls to DocValueFormat.parse methods to handle parsing of user-supplied
includeandexcludestrings intermsandsignificant_termsaggregations into a form that can be compared with doc valuesCloses #17705