Fix calculation of age of pending tasks #15995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasontedor
added
>bug
:Data Management/Stats
Member
There was a problem hiding this comment.
Could you just take a long here?
Member
|
LGTM |
Contributor
|
LGTM2. Good catch. |
This commit addresses a time unit conversion bug in calculating the age of a PrioritizedRunnable. The issue was an incorrect conversion from nanoseconds to milliseconds as instead the conversion was to microseconds. This leads to the timeInQueue metric for pending tasks to be off by three orders of magnitude.
jasontedor
added a commit
that referenced
this pull request
Jan 15, 2016
Fix calculation of age of pending tasks Closes #15988
jasontedor
added a commit
that referenced
this pull request
Jan 17, 2016
This commit adds a test for calculating the age of PrioritizedRunnable that allows real clock time to elapse. The test ensures that at least one millisecond has passed, and that the resolution of System#nanoTime on the underlying system is actually able to detect this. Relates #15995
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses a time unit conversion bug in calculating the age
of a PrioritizedRunnable. The issue was an incorrect conversion from
nanoseconds to milliseconds as instead the conversion was to
microseconds. This leads to the timeInQueue metric for pending tasks to
be off by three orders of magnitude.
Closes #15988