Skip to content

Conversation

@mikemccand
Copy link
Contributor

I only limit bulk and index thread pools.

Closes #15582

@jpountz
Copy link
Contributor

jpountz commented Dec 22, 2015

I'm also curious if there is a way to give feedback to users without breaking existing installations. Maybe @s1monw has a clue?

@spinscale spinscale added v2.2.1 and removed v2.2.0 labels Dec 23, 2015
@s1monw
Copy link
Contributor

s1monw commented Jan 5, 2016

@mikemccand to fix this the right way I agree we should be loud. I think we have to upgrade the settings in the clusterstate first and that can on work well if we do it only in a major version? On the other hand what if you have machines with 8 CPUs and others with 80 CPU? I mean this is really a per-node setting and I think we should maybe not allow to set this globally? I think you patch is good as a first step but we should really think about how to expose these settings?

@mikemccand
Copy link
Contributor Author

I talked to @s1monw ... we decided to add a logger.warn here if you tried to set to a too-large value, but otherwise be silent for now, and to open a separate issue that this setting should not be global and dynamically updatable.

@mikemccand
Copy link
Contributor Author

OK I pushed another commit w/ the feedback; I think it's ready.

@s1monw
Copy link
Contributor

s1monw commented Jan 8, 2016

LGTM

@mikemccand
Copy link
Contributor Author

Thanks @s1monw, I'll port to 2.2.0 as well.

@mikemccand mikemccand added v2.2.0 and removed v2.2.1 labels Jan 8, 2016
mikemccand pushed a commit that referenced this pull request Jan 8, 2016
Limit the max size of bulk and index thread pools to bounded number of processors
@mikemccand mikemccand merged commit d3d41fc into elastic:master Jan 8, 2016
mikemccand added a commit to mikemccand/elasticsearch that referenced this pull request May 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants