Treat mappings at an index-level feature. #15142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpountz
added
>bug
:Search Foundations/Mapping
Contributor
Author
There was a problem hiding this comment.
good catch: fixed. For the record this was a pre-existing issue.
Contributor
|
left some comments. |
Contributor
|
LGTM. Thanks @jpountz |
jpountz
force-pushed
the
fix/index_level_mappings
branch
2 times, most recently
from
04c61d7 to
0f269cf
Compare
Today we try to have type-level granularity when dealing with mappings. This does not play well with the cross-type validations that we are adding. For instance we prevent the `_parent` field to point to an existing type. This validation would be skipped today in the case of dedicated master nodes, since those master nodes would only create the type that is being updated when updating a mapping.
jpountz
force-pushed
the
fix/index_level_mappings
branch
from
0f269cf to
79188ed
Compare
jpountz
added a commit
that referenced
this pull request
Dec 2, 2015
Treat mappings at an index-level feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we try to have type-level granularity when dealing with mappings. This
does not play well with the cross-type validations that we are adding. For
instance we prevent the
_parentfield to point to an existing type. Thisvalidation would be skipped today in the case of dedicated master nodes, since
those master nodes would only create the type that is being updated when
updating a mapping.