-
Notifications
You must be signed in to change notification settings - Fork 25.5k
Make resolve conflict in transport version its own task #134842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make resolve conflict in transport version its own task #134842
Conversation
This commit moves the action for resolving merge conflicts in transport version files a separate task instead of a command line flag to generate.
Pinging @elastic/es-core-infra (Team:Core/Infra) |
🔍 Preview links for changed docs |
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
t.into(resourceRoot + "/definitions", c -> c.from(generateManifestTask)); | ||
}); | ||
|
||
Consumer<GenerateTransportVersionDefinitionTask> generationConfiguration = t -> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, if we made this an Action
then we could make applying this to tasks slightly more ergonomic. Such as:
Action<MyTask> commonConfig = t -> { t.setGroup("foo") };
project.getTasks.register("myTask", MyTask.class, commonConfig).configure {
// unique config
};
or
project.getTasks.register("myTask", MyTask.class, t -> {
// unique config
}.configure(commonConfig);
Pick your preferred style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about this, I'll do it the next time I tweak this file.
💔 Backport failed
You can use sqren/backport to manually backport by running |
This commit moves the action for resolving merge conflicts in transport version files a separate task instead of a command line flag to generate.
This commit moves the action for resolving merge conflicts in transport version files a separate task instead of a command line flag to generate.
This commit moves the action for resolving merge conflicts in transport version files a separate task instead of a command line flag to generate.
This commit moves the action for resolving merge conflicts in transport version files a separate task instead of a command line flag to generate.
This commit moves the action for resolving merge conflicts in transport version files a separate task instead of a command line flag to generate.
This commit moves the action for resolving merge conflicts in transport version files a separate task instead of a command line flag to generate.
This commit moves the action for resolving merge conflicts in transport version files a separate task instead of a command line flag to generate.