Vectorize BQVectorUtils#packAsBinary #132923
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #132820, the method BQVectorUtils#packAsBinary can be easily vectorize by using a helper array that defines the shifts we need to apply to the vector elements.
For 128 bits in my mac, the improvements are almost 2x:
For 256 bits on a GCP instancem looks similar:
For 512 bits on a GCP instance does look so great, still an improvement though. I tried to optimize this case by doing two bytes at a time and shifting the second to build a short but it did not help.
relates #132761