Upgrade to lucene-5.3.0. #13239
Merged
Upgrade to lucene-5.3.0. #13239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From a user perspective, the main benefit from this upgrade is that the new Lucene53Codec has disk-based norms. The elasticsearch directory has been fixed to load these norms through mmap instead of nio. Other changes include the removal of `max_thread_states`, the fact that PhraseQuery and BooleanQuery are now immutable, and that deleted docs are now applied on top of the Scorer API. This change introduces a couple of `AwaitsFix`s but I don't think it should hold us from merging.
Contributor
|
looks great, +1 |
Contributor
|
👍 I just did this change myself locally but you beat me to it. |
clintongormley
added
:Core/Infra/Core
Contributor
|
Is there any possibility to include this in the 2.0.0 release? |
Contributor
Author
|
@dpursehouse We are in the process of stabilizing 2.0 and this is a big change, so it won't be backported. The good news however is that we aim at releasing 2.1 relatively soon after 2.0. |
ghost
mentioned this pull request
jpountz
added a commit
to jpountz/elasticsearch
that referenced
this pull request
Dec 17, 2015
This is a bug that I introduced in elastic#13239 while thinking that the differences were due to changes in Lucene: extractUnknownQuery is also called when span extraction already succeeded, so we should only fall back to Weight.extractTerms if no spans have been extracted yet. Close elastic#15291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a user perspective, the main benefit from this upgrade is that the new
Lucene53Codec has disk-based norms. The elasticsearch directory has been fixed
to load these norms through mmap instead of nio.
Other changes include the removal of
max_thread_states, the fact thatPhraseQuery and BooleanQuery are now immutable, and that deleted docs are now
applied on top of the Scorer API.
This change introduces a couple of
AwaitsFixs but I don't think it shouldhold us from merging.