-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[Test] Fix test022InstallPluginsFromLocalArchive #131353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
elasticsearchmachine
merged 4 commits into
elastic:main
from
slobodanadamovic:fix-test022InstallPluginsFromLocalArchive
Jul 30, 2025
Merged
[Test] Fix test022InstallPluginsFromLocalArchive #131353
elasticsearchmachine
merged 4 commits into
elastic:main
from
slobodanadamovic:fix-test022InstallPluginsFromLocalArchive
Jul 30, 2025
+1
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of plugin archives changed and triggered the assertion. Changing the assertion to check for `analysis-icu` plugin archive instead of asserting on number of archives. This will always fail when new plugin is added (like microsoft-graph-authz). Resolves elastic#116866
Collaborator
|
Pinging @elastic/es-delivery (Team:Delivery) |
jozala
approved these changes
Jul 21, 2025
Contributor
jozala
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement. LGTM.
jozala
added a commit
to breskeby/elasticsearch
that referenced
this pull request
Jul 28, 2025
as in elastic#131353 Changing the assertion to check for analysis-icu plugin archive instead of asserting on number of archives. This will always fail when new plugin is added (like microsoft-graph-authz).
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 29, 2025
* Standardize on docker image arch classifier (#130643) * The number of plugin archives changed and triggered the assertion as in #131353 Changing the assertion to check for analysis-icu plugin archive instead of asserting on number of archives. This will always fail when new plugin is added (like microsoft-graph-authz). --------- Co-authored-by: Mariusz Józala <[email protected]> Co-authored-by: Mariusz Jozala <[email protected]>
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
auto-merge-without-approval
Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!)
backport pending
:Delivery/Packaging
RPM and deb packaging, tar and zip archives, shell and batch scripts
Team:Delivery
Meta label for Delivery team
>test
Issues or PRs that are addressing/adding tests
v8.19.1
v9.1.1
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of plugin archives changed and triggered the assertion.
Changing the assertion to check for
analysis-icuplugin archiveinstead of asserting on number of archives. This will always fail
when new plugin is added (like microsoft-graph-authz).
Resolves #116866