Remove sync from ConnectionTarget#toString
#128656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When introduced in elastic#39629 we needed to acquire `mutex` here because the `toString()` result included a mutable field, but we dropped that field in elastic#77295. This commit removes the now-unnecessary synchronization.
DaveCTurner
added
>non-issue
:Distributed Coordination/Network
elasticsearchmachine
added
the
Team:Distributed Coordination
Collaborator
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
schase-es
approved these changes
Jun 4, 2025
Contributor
|
Oof, I realized I just commented and didn't approve... |
DaveCTurner
added
auto-merge-without-approval
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Jun 4, 2025
When introduced in elastic#39629 we needed to acquire `mutex` here because the `toString()` result included a mutable field, but we dropped that field in elastic#77295. This commit removes the now-unnecessary synchronization.
Collaborator
💚 Backport successful
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When introduced in #39629 we needed to acquire
mutexhere because thetoString()result included a mutable field, but we dropped that fieldin #77295. This commit removes the now-unnecessary synchronization.