Deduplicate created objects when deserializing InternalAggregations in SearchResponse #124296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
iverase
added
the
auto-backport
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Mar 10, 2025
…n SearchResponse (elastic#124296) It should help in case of cross cluster search.
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Mar 10, 2025
…n SearchResponse (elastic#124296) It should help in case of cross cluster search. # Conflicts: # server/src/main/java/org/elasticsearch/action/search/SearchResponse.java
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Mar 10, 2025
…n SearchResponse (elastic#124296) It should help in case of cross cluster search. # Conflicts: # server/src/main/java/org/elasticsearch/action/search/SearchResponse.java
georgewallace
pushed a commit
to georgewallace/elasticsearch
that referenced
this pull request
Mar 11, 2025
…n SearchResponse (elastic#124296) It should help in case of cross cluster search.
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Mar 13, 2025
…n SearchResponse (elastic#124296) It should help in case of cross cluster search.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking into heap dump of a cluster performing a CCS, I observed a huge amount of duplicated objects coming from deserializing the internal aggregations from the remove clusters search responses:
We observed a very similar situation in coordination nodes for standard searches and it was introduced a mechanism to deduplicate objects inside DelayedWritable. This commit proposes to expose the deduplicator stream and use it when deserializing InternalAggregations in SearchResponse.