Revert fail-fast disconnect strategy for _resolve/cluster
#124241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the first solution for the long wait times that user could potentially see when invoking this API. However, we reverted this change in favour of the new timeout parameter. Unfortunately, the change in disconnect strategy targeted more broader versions than the timeout parameter PR (which contained the revert). This PR fixes this discrepancy.
pawankartik-elastic
added
>bug
auto-backport
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
Collaborator
|
Hi @pawankartik-elastic, I've created a changelog YAML for you. |
smalyshev
approved these changes
Mar 6, 2025
Collaborator
💚 Backport successful
|
pawankartik-elastic
added a commit
to pawankartik-elastic/elasticsearch
that referenced
this pull request
Mar 7, 2025
…124241) * Revert fail-fast disconnect strategy for `_resolve/cluster` This was the first solution for the long wait times that user could potentially see when invoking this API. However, we reverted this change in favour of the new timeout parameter. Unfortunately, the change in disconnect strategy targeted more broader versions than the timeout parameter PR (which contained the revert). This PR fixes this discrepancy. * Update docs/changelog/124241.yaml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Mar 7, 2025
…#124368) * Revert fail-fast disconnect strategy for `_resolve/cluster` This was the first solution for the long wait times that user could potentially see when invoking this API. However, we reverted this change in favour of the new timeout parameter. Unfortunately, the change in disconnect strategy targeted more broader versions than the timeout parameter PR (which contained the revert). This PR fixes this discrepancy. * Update docs/changelog/124241.yaml
pawankartik-elastic
deleted the
pkar/revert-disconn-strategy-resolve-cluster
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the disconnect strategy was the first solution for the long wait times that user could potentially see when invoking this API. However, we reverted this change in favour of the new timeout parameter. Unfortunately, the change in disconnect strategy targeted more broader versions than the timeout parameter PR (which contained the revert). This PR fixes this discrepancy.
Problematic PR: #119516.
PR that reverted the problematic commit with a proper fix (timeout parameter): #120542. Unfortunately, this is the PR that did not properly back port the fix because it was decided that it'd be an enhancement rather than a fix.