Query refactoring: SpanNotQueryBuilder and Parser #12365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
left a few comments |
Member
Author
Member
|
sounds good @cbuescher |
cbuescher
force-pushed
the
feature/query-refactoring-spannot
branch
from
7b924bf to
96b2829
Compare
Member
Author
|
Added separate test for |
Member
|
LGTM |
Moving the query building functionality from the parser to the builders new doToQuery() method analogous to other recent query refactorings. Relates to elastic#10217 Closes elastic#12365
cbuescher
force-pushed
the
feature/query-refactoring-spannot
branch
from
457c367 to
7f88cc5
Compare
cbuescher
added a commit
that referenced
this pull request
Jul 22, 2015
…annot Query refactoring: SpanNotQueryBuilder and Parser
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Moving the query building functionality from the parser to the builders new doToQuery() method analogous to other recent query refactorings. Relates to elastic#10217 Closes elastic#12365
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…ring-spannot Query refactoring: SpanNotQueryBuilder and Parser
Member
|
This change is breaking for the Java API as it removes setter for mandatory include/exclude span query clause, which needs to be set in the constructor instead. |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the query building functionality from the parser to the builders
new doToQuery() method analogous to other recent query refactorings.
Relates to #10217