Remove local param from field mapping API spec
#122922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `local` param for the `GetFieldMapping` API was deprecated in elastic#55014 and I think elastic#57265 aimed to propogate that deprecation to the REST API spec, but it changed `get_mapping.json` instead of `get_field_mapping.json`. elastic#55100 removed the `local` param for the _field_ mapping API so we can safely remove the field from the spec and remove the YAML test.
nielsbauman
added
>non-issue
:Data Management/Indices APIs
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
localparam for theGetFieldMappingAPI was deprecated in #55014 and I think #57265 aimed to propogate that deprecation to the REST API spec, but it changedget_mapping.jsoninstead ofget_field_mapping.json. #55100 removed thelocalparam for the field mapping API so we can safely remove the field from the spec and remove the YAML test.