Enforce field names do not contain dot #12068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Field names containing dots can cause problems. For example, @jpountz made this recreation which cause no error, but can result in a serialization exception if the type already exists: https://gist.github.com/jpountz/8c66817e00a322b81f85 But this is not just a potential conflict. It also has larger problems, since only the leaf mapper is created. The intermediate "foo" object field would not exist if only "foo.bar" was in the mappings. This change forbids the use of dots in field names. It also fixes an issue with passing through the update_all_types setting, which was always set to true whenever a type already existed (!). I do not think we should worry about backwards compatibility here. This should be a hard break (and added to the migration plugin).
rjernst
added
>breaking
v2.0.0-beta1
:Search Foundations/Mapping
|
The change looks good to me, but I'd like to get @clintongormley 's take on this. |
|
+1 |
rjernst
added a commit
that referenced
this pull request
Jul 7, 2015
Mappings: Enforce field names do not contain dot
clintongormley
changed the title
This was referenced Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Field names containing dots can cause problems. For example, @jpountz
made this recreation which causes no error, but can result in a
serialization exception if the type already exists:
https://gist.github.com/jpountz/8c66817e00a322b81f85
But this is not just a potential conflict. It also has larger problems,
since only the leaf mapper is created. The intermediate "foo" object
field would not exist if only "foo.bar" was in the mappings.
This change forbids the use of dots in field names. It also
fixes an issue with passing through the update_all_types setting,
which was always set to true whenever a type already existed (!).
I do not think we should worry about backwards compatibility here. This
should be a hard break (and added to the migration plugin).