-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Use directory name as project name for libs #115720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
dbb4ab4
f2d47aa
6fa969b
5e8cfe7
137a512
28f30c6
49706c1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,19 +13,19 @@ apply plugin: 'elasticsearch.mrjar' | |
| dependencies { | ||
| // This dependency is used only by :libs:core for null-checking interop with other tools | ||
| compileOnly "com.google.code.findbugs:jsr305:3.0.2" | ||
| compileOnly project(':libs:elasticsearch-logging') | ||
| compileOnly project(':libs:logging') | ||
|
|
||
| testImplementation "com.carrotsearch.randomizedtesting:randomizedtesting-runner:${versions.randomizedrunner}" | ||
| testImplementation "junit:junit:${versions.junit}" | ||
| testImplementation "org.hamcrest:hamcrest:${versions.hamcrest}" | ||
|
|
||
| testImplementation(project(":test:framework")) { | ||
| exclude group: 'org.elasticsearch', module: 'elasticsearch-core' | ||
| exclude group: 'org.elasticsearch', module: 'core' | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does the gradle "module name" matter? This PR produces the same artifact ids, though the "name" attribute in the pom is different. Is there a way to control this module name in gradle? I could only find archivesName which we set as the artifactId.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The "name" is purely descriptive so I think it's fine if they are different. So long as the artifactId is the same we won't have to deal with updating dependencies.
|
||
| } | ||
| } | ||
|
|
||
| tasks.named('forbiddenApisMain').configure { | ||
| // :libs:elasticsearch-core does not depend on server | ||
| // :libs:core does not depend on server | ||
| // TODO: Need to decide how we want to handle for forbidden signatures with the changes to server | ||
| replaceSignatureFiles 'jdk-signatures' | ||
| } | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By using the directory name (which hasn't changed) this allows for bwc builds to run, even though this change has not yet been backported.