Removing the legacy global template from yaml rest tests #115588
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It looks like this was originally added in #30539. I'm guessing that it was to occasionally use 2 shards once we defaulted the tests to 1 shard. |
Member
Author
|
Closed in favor of #115799 in order to not break serverless |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We randomly rarely create a legacy global template in our yaml rest tests. Legacy templates are deprecated at this point, and the value we get from randomly injecting a legacy global template is dwarfed by the cost of randomly rarely failing yaml rest tests. In this PR I'm proposing we stop using them in our yaml rest tests.