Remove version based logic from IpFieldMapper and DateFieldMapper #113023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have logic that throws exception when parsing empty null_value for ip and date field mapper only for indices created from 8.0 and onwards. This conditional can now be removed.
javanna
added
:Search Foundations/Mapping
elasticsearchmachine
added
Team:StorageEngine
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
martijnvg
approved these changes
Sep 17, 2024
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
LGTM - looks like PR CI failed due to a check style error.
cbuescher
added a commit
to cbuescher/elasticsearch
that referenced
this pull request
Dec 19, 2024
…pper (elastic#113023)" This reverts commit de5b00d.
cbuescher
added a commit
to cbuescher/elasticsearch
that referenced
this pull request
Dec 19, 2024
This restores deprecation warnings previously removed with elastic#113023 and restores some additional tests due to N-2 read-only support.
cbuescher
added a commit
that referenced
this pull request
Dec 19, 2024
This restores deprecation warnings previously removed with #113023 and restores some additional tests due to N-2 read-only support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have logic that throws exception when parsing empty null_value for ip and date field mapper only for indices created from 8.0 and onwards. This conditional can now be removed.
Relates to #62487