ESQL: Convert some PhysicalPlans to NamedWriteable #112764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This converts half of hte remaining `PhysicalPlan`s to `NamedWriteable` to line up better with the rest of Elasticsearch.
nik9000
added
>non-issue
auto-backport-and-merge
:Analytics/ES|QL
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
craigtaverner
approved these changes
Sep 11, 2024
| this.parser = parser; | ||
| } | ||
|
|
||
| private static GrokExec readFrom(StreamInput in) throws IOException { |
Contributor
There was a problem hiding this comment.
I'm curious why you used a private static factory function here instead of a constructor like in all other classes?
Member
Author
There was a problem hiding this comment.
It needs source in two places and those places aren't really compatible with a ctor. It's funky, but I figure I'll use whatever takes the minimum amount of typing.
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Sep 12, 2024
This converts half of hte remaining `PhysicalPlan`s to `NamedWriteable` to line up better with the rest of Elasticsearch.
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts half of the remaining
PhysicalPlans toNamedWriteableto line up better with the rest of Elasticsearch.