Add UpdateForV10 annotation #112281
Merged
Add UpdateForV10 annotation #112281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisHegarty
added
:Core/Infra/Core
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
DaveCTurner
approved these changes
Aug 28, 2024
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM2.
Note that there's already a couple of places we mention the string UpdateForV10 in a comment which can now become proper annotations with this change. We can do that here or in a follow-up PR.
Contributor
Author
Yes, I've seen these. Let's do that in a follow up. |
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Aug 30, 2024
In preparation for the next major release of Elasticsearch, this commit adds the UpdateForV10 annotation.
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
In preparation for the next major release of Elasticsearch, this commit adds the UpdateForV10 annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for the next major release of Elasticsearch, this commit adds the UpdateForV10 annotation.
We're already starting to use this over in the lucene_snapshot_10 branch, so best upstream it to main where it may be used elsewhere when refactoring and/or cleaning up code marked UpdateForV9.