[ES|QL] Combine 3 commonTypes into one #112220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
fang-xing-esql
requested review from
bpintea,
costin,
nik9000 and
not-napoleon
nik9000
approved these changes
Aug 27, 2024
Member
nik9000
left a comment
nik9000
left a comment
There was a problem hiding this comment.
Nice! You've even removed a few of the types that I didn't think we'd need. I'm not the right person to make sure they aren't needed, but I think you are that person. So! Given that, merge when the tests are happy!
fang-xing-esql
commented
Aug 27, 2024
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/type/EsqlDataTypeConverter.java
Outdated
Show resolved
Hide resolved
bpintea
approved these changes
Aug 27, 2024
x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/type/EsqlDataTypeConverter.java
Outdated
Show resolved
Hide resolved
astefan
reviewed
Aug 28, 2024
.../plugin/esql/src/test/java/org/elasticsearch/xpack/esql/type/EsqlDataTypeConverterTests.java
Outdated
Show resolved
Hide resolved
astefan
approved these changes
Aug 29, 2024
Contributor
astefan
left a comment
astefan
left a comment
There was a problem hiding this comment.
LGTM
Left one minor comment regarding the list of known data types in several places.
.../plugin/esql/src/test/java/org/elasticsearch/xpack/esql/type/EsqlDataTypeConverterTests.java
Outdated
Show resolved
Hide resolved
.../plugin/esql/src/test/java/org/elasticsearch/xpack/esql/type/EsqlDataTypeConverterTests.java
Outdated
Show resolved
Hide resolved
dakrone
pushed a commit
to dakrone/elasticsearch
that referenced
this pull request
Aug 30, 2024
Combine 3 commonTypes into one.
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
Combine 3 commonTypes into one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #112167
Combine commonTypes.