ESQL: don't lose the original casting error message #111968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Collaborator
|
Hi @astefan, I've created a changelog YAML for you. |
Contributor
|
Argh, sorry @fang-xing-esql , I broke it! This used to work before this tweak #111475 (comment) I think it's nicer, though, that we don't have to resort to |
alex-spies
approved these changes
Aug 19, 2024
Contributor
alex-spies
left a comment
alex-spies
left a comment
There was a problem hiding this comment.
LGTM, thanks @astefan !
lkts
pushed a commit
to lkts/elasticsearch
that referenced
this pull request
Aug 20, 2024
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The String implicit casting is resolving a string Literal to an UnresolvedAttribute if the conversion fails and it's, also, adding a specific error message. But, later in the resolving process this message is lost when ES|QL tries to find field names suggestions. This PR stops the resolution if there is already an UnresolvedAttribute with a specific error message (like the one coming from implicit casting resolution).
Fixes #111967