Skip to content

Unmute SnapshotStatusApisIT#testInfiniteTimeout #108178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2024
Merged

Unmute SnapshotStatusApisIT#testInfiniteTimeout #108178

merged 1 commit into from
May 3, 2024

Conversation

@arteam
Copy link
Contributor

@arteam arteam commented May 2, 2024 •
edited
Loading

This test doesn't fail anymore, I've run it 1000 times locally.

This test got introduced in #107050, and I believe the test got fixed in #107675. Unfortunately, the got muted before #107675 got merged, so I can't confirm that PR actually fixed the test on CI.

@arteam
Unmute SnapshotStatusApisIT#testInfiniteTimeout
0d1c2c2 
This test doesn't fail anymore, I've run it 1000 times locally. This test
got introduced in #107050, and I believe the test got fixed in #107675.
Unfortunately, the got muted before #107675 got merged, so I can't confirm
that #107675 fixed the test on CI.
@arteam arteam added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. labels May 2, 2024
@elasticsearchmachine elasticsearchmachine added v8.15.0 Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. labels May 2, 2024
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented May 2, 2024

Pinging @elastic/es-distributed (Team:Distributed)

ywangd
ywangd approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did #107675 fix it? Should it resolve #107405?

@arteam arteam merged commit 63294e7 into main May 3, 2024
@arteam arteam deleted the unmute-snapshot-status-apis-infinite-timeout branch May 3, 2024 08:45
@arteam
Copy link
Contributor Author

arteam commented May 3, 2024

Thank you! Yes, I believe #107675 fixed the test. I've run it locally 1000 times without failures. Let's run this test on CI and it keeps failing, I will re-open #107405.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ywangd ywangd ywangd approved these changes

Assignees

No one assigned

Labels

:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v8.15.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arteam @elasticsearchmachine @ywangd