Pulling KeyValueProcessor.logAndBuildException() into AbstractProcessor #106931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>non-issue
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
joegallo
approved these changes
Mar 29, 2024
rjernst
reviewed
Mar 29, 2024
| if (logger.isTraceEnabled()) { | ||
| logger.trace(message, throwable); | ||
| } else { | ||
| logger.warn(longMessage); |
Member
There was a problem hiding this comment.
Logging a warning on every ingest processor error seems like it could overwhelm the log, eg if a simple user error is hammered against the system. Why do we need to log user errors?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the logAndBuildException() method into AbstractProcessor so that it can be used by other processors besides KeyValueProcessor.