Use a regex rather than a string match #104886
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>non-issue
:Data Management/Ingest Node
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
approved these changes
Jan 30, 2024
Member
masseyke
left a comment
masseyke
left a comment
There was a problem hiding this comment.
I'm giving this one an uncomfortable LGTM
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Jan 30, 2024
joegallo
added a commit
to joegallo/elasticsearch
that referenced
this pull request
Jan 30, 2024
Contributor
Author
Contributor
Author
++, I suspect there's something interesting here, but I don't want to dig into it now -- I filed #104950 so that it's not just completely forgotten (or only on my private todo list to maybe return to one day). |
joegallo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an exception from CI. In all my local testing the
error.reasonis"error-message", but in some circumstances in CI theerror.reasonis"fail_processor_exception: error-message". I don't understand why that is, but this unbreaks CI until I can investigate further.Quick followup to #104585