Skip to content

Conversation

@thecoop
Copy link
Member

@thecoop thecoop commented Nov 15, 2023

This parameter is only null, so I think it can probably go...

@thecoop thecoop added >refactoring :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Nov 15, 2023
@elasticsearchmachine elasticsearchmachine added v8.12.0 Team:Data Management Meta label for data/management team labels Nov 15, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@dakrone
Copy link
Member

dakrone commented Nov 15, 2023

@droberts195 I think you added this parameter, going from the Git blame. Do you have any reason it couldn't be removed?

@droberts195
Copy link

I added the parameter in #73232 to aid the switchover of ML and transform templates from legacy templates to composable templates. During the switchover period it was possible that we'd need to install a newer legacy template rather than switching to a composable template while the cluster was in a mixed-version state where the older versions didn't understand composable templates. That situation can never happen now because any version from 7.17 upwards must understand composable templates.

It's OK to get rid of the argument. It's interesting that the SAML template is still a legacy template. The changes in this PR are making the checkTemplateExistsAndIsUpToDate method specific to legacy templates now, so might make any subsequent shift to composable templates for security harder. But if you're happy to defer that work to later then this change won't cause any problems.

Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thecoop thecoop merged commit a2a7da9 into elastic:main Nov 16, 2023
@thecoop thecoop deleted the remove-composable-template-version branch November 16, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Data Management/ILM+SLM Index and Snapshot lifecycle management >refactoring Team:Data Management Meta label for data/management team v8.12.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants