Compute maps up front in SnapshotRetentionTask #100070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than computing a map of all relevant snapshots (per repo and policy) repeatedly, once for every snapshot, let's compute them all up front.
DaveCTurner
added
>non-issue
:Data Management/ILM+SLM
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
Contributor
Author
|
@elasticmachine please run elasticsearch-ci/part-2 |
joegallo
reviewed
Sep 29, 2023
| static boolean snapshotEligibleForDeletion( | ||
| SnapshotInfo snapshot, | ||
| Map<String, List<SnapshotInfo>> allSnapshots, | ||
| Map<String, Map<String, Map<SnapshotId, RepositoryData.SnapshotDetails>>> allSnapshotDetails, |
Contributor
There was a problem hiding this comment.
You're straining the very definition of data structures here, David. 😆
Contributor
Author
There was a problem hiding this comment.
If this was Haskell they'd be type synonyms.
joegallo
approved these changes
Sep 29, 2023
Contributor
joegallo
left a comment
joegallo
left a comment
There was a problem hiding this comment.
+1, I'm a bit +-0 on the (internal only) mutability of the map of maps of maps, but I'm willing to go along for the ride on this and some follow up PRs and revisit this when the dust settles.
DaveCTurner
deleted the
2023/09/29/SnapshotRetentionTask-snapshot-maps-up-front
branch
piergm
pushed a commit
to piergm/elasticsearch
that referenced
this pull request
Oct 2, 2023
Rather than computing a map of all relevant snapshots (per repo and policy) repeatedly, once for every snapshot, let's compute them all up front.
jakelandis
pushed a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 2, 2023
Rather than computing a map of all relevant snapshots (per repo and policy) repeatedly, once for every snapshot, let's compute them all up front.
DaveCTurner
restored the
2023/09/29/SnapshotRetentionTask-snapshot-maps-up-front
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than computing a map of all relevant snapshots (per repo and
policy) repeatedly, once for every snapshot, let's compute them all up
front.