SnapshotDetails-based SnapshotRetentionConfiguration #100058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today `SnapshotRetentionConfiguration` requires a full set of `SnapshotInfo` objects to do its retention computations, but these can be fairly large and expensive to obtain in a large repository. Moreover it doesn't need the whole `SnapshotInfo`, everything it needs is held in `SnapshotDetails` which is usually held in-memory on the master node in most cases, and even if not we can get them from the root blob. This commit reworks `SnapshotRetentionConfiguration` to do its computations based on `SnapshotDetails`.
DaveCTurner
added
>non-issue
:Data Management/ILM+SLM
elasticsearchmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
deleted the
2023/09/29/SnapshotRetentionConfiguration-SnapshotDetails
branch
andreidan
reviewed
Sep 29, 2023
Contributor
andreidan
left a comment
andreidan
left a comment
There was a problem hiding this comment.
A bit late :), but LGTM
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Sep 29, 2023
A follow-on from elastic#100058 to make `SnapshotRetentionConfiguration` even more `SnapshotDetails`-based.
This was referenced Sep 29, 2023
DaveCTurner
added a commit
that referenced
this pull request
Sep 29, 2023
A follow-on from #100058 to make `SnapshotRetentionConfiguration` even more `SnapshotDetails`-based.
piergm
pushed a commit
to piergm/elasticsearch
that referenced
this pull request
Oct 2, 2023
Today `SnapshotRetentionConfiguration` requires a full set of `SnapshotInfo` objects to do its retention computations, but these can be fairly large and expensive to obtain in a large repository. Moreover it doesn't need the whole `SnapshotInfo`, everything it needs is in `SnapshotDetails` which is in the root `RepositoryData` blob and usually held in-memory on the master node. This commit reworks `SnapshotRetentionConfiguration` to do its computations based on `SnapshotDetails`.
piergm
pushed a commit
to piergm/elasticsearch
that referenced
this pull request
Oct 2, 2023
…0065) A follow-on from elastic#100058 to make `SnapshotRetentionConfiguration` even more `SnapshotDetails`-based.
jakelandis
pushed a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 2, 2023
Today `SnapshotRetentionConfiguration` requires a full set of `SnapshotInfo` objects to do its retention computations, but these can be fairly large and expensive to obtain in a large repository. Moreover it doesn't need the whole `SnapshotInfo`, everything it needs is in `SnapshotDetails` which is in the root `RepositoryData` blob and usually held in-memory on the master node. This commit reworks `SnapshotRetentionConfiguration` to do its computations based on `SnapshotDetails`.
jakelandis
pushed a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 2, 2023
…0065) A follow-on from elastic#100058 to make `SnapshotRetentionConfiguration` even more `SnapshotDetails`-based.
DaveCTurner
restored the
2023/09/29/SnapshotRetentionConfiguration-SnapshotDetails
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today
SnapshotRetentionConfigurationrequires a full set ofSnapshotInfoobjects to do its retention computations, but these canbe fairly large and expensive to obtain in a large repository. Moreover
it doesn't need the whole
SnapshotInfo, everything it needs is inSnapshotDetailswhich is in the rootRepositoryDatablob and usuallyheld in-memory on the master node.
This commit reworks
SnapshotRetentionConfigurationto do itscomputations based on
SnapshotDetails.