Inline SnapshotRetentionConfiguration#getSnapshotDeletionPredicate #100053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only ever test each instance this predicate once, immediately after creating it, so we may as well just convert it into a regular method that returns `boolean` instead. More preliminary work before fixing elastic#99953
elasticsearchmachine
added
needs:triage
DaveCTurner
added
>refactoring
:Data Management/ILM+SLM
Contributor
Author
|
Tip for reviews: hide whitespace changes :) |
elasticsearchmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
DaveCTurner
added
the
auto-merge-without-approval
DaveCTurner
deleted the
2023/09/29/getSnapshotDeletionPredicate-unnecessary
branch
piergm
pushed a commit
to piergm/elasticsearch
that referenced
this pull request
Oct 2, 2023
…lastic#100053) We only ever test each instance of this predicate once, immediately after creating it, so we may as well just convert it into a regular method that returns `boolean` instead. More preliminary work before fixing elastic#99953
jakelandis
pushed a commit
to jakelandis/elasticsearch
that referenced
this pull request
Oct 2, 2023
…lastic#100053) We only ever test each instance of this predicate once, immediately after creating it, so we may as well just convert it into a regular method that returns `boolean` instead. More preliminary work before fixing elastic#99953
DaveCTurner
restored the
2023/09/29/getSnapshotDeletionPredicate-unnecessary
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only ever test each instance of this predicate once, immediately
after creating it, so we may as well just convert it into a regular
method that returns
booleaninstead.More preliminary work before fixing #99953