-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Open
Labels
:Distributed Coordination/NetworkHttp and internode communication implementationsHttp and internode communication implementations>bug>tech debtTeam:Distributed (Obsolete)Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
Description
TcpTransportChannel#sendResponse ends up calling TransportResponse#decRef once the response is sent, but the other implementations (notably DirectResponseChannel#sendResponse) do not. I don't have evidence that this is observable as a bug today but I expect it will bite us at some point in the future.
I'd rather we didn't have methods that implicitly called decRef like that, it's so much trappier than having every incRef/decRef pair explicitly co-located, so I'd prefer to add an on-sent listener argument to TransportChannel#sendResponse.
Relates #76474
Metadata
Metadata
Assignees
Labels
:Distributed Coordination/NetworkHttp and internode communication implementationsHttp and internode communication implementations>bug>tech debtTeam:Distributed (Obsolete)Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.