Ec2NetworkTests don't assert much

[nik9000]

The Ec2NetworkTests sneakily don't assert much of anything. They look like:

        NetworkService networkService = new NetworkService(Collections.singletonList(new Ec2NameResolver(nodeSettings)));
        // TODO we need to replace that with a mock. For now we check the URL we are supposed to reach.
        try {
            networkService.resolveBindHostAddresses(null);
            // ------- See how there isn't a fail here?!
        } catch (IOException e) {
            assertThat(e.getMessage(), containsString("local-ipv4"));
        }

It looks like they always just fall out of the catch statement, asserting nothing in particular. This seem bad.

[elasticmachine]

Pinging @elastic/es-distributed