CCE when re-throwing "shard not available" exception in TransportShardMultiGetAction

[sabi0]

elasticsearch/server/src/main/java/org/elasticsearch/action/get/TransportShardMultiGetAction.java

Line 95 in cfb3014

throw (ElasticsearchException) e;

TransportActions.isShardNotAvailableException() is also true for Lucene's AlreadyClosedException, which is not ElasticsearchException sub-class.
When that happens CCE will be thrown instead of re-throwing the actual exception.

[elasticmachine]

Pinging @elastic/es-core-infra

[ashokn]

I would like to work on this issue

[onvik]

@ashokn missed your comment and submitted a PR #32185.

@sabi0 @dnhatn let me know if my change is fine.

[sabi0]

Searching for usages of isShardNotAvailableException reveals a couple more places in the code with the same problem: TransportShardMultiPercolateAction, TransportShardMultiTermsVectorAction.

[onvik]

@sabi0 I can't find TransportShardMultiPercolateAction in master, I have fixed for TransportShardMultiTermsVectorAction.

[sabi0]

@itsnotv Sorry, I was looking at an older version of the source. There isn't TransportShardMultiPercolateAction in master anymore, indeed.