org.elasticsearch.painless.ArrayTests tests fail when running on JDK 11

[alpar-t]

feature branch: feature/31230_gradle48_jdk11

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+31230_gradle48_jdk11+matrix-java-feature-branch/5/ES_BUILD_JAVA=java10,ES_RUNTIME_JAVA=java11,nodes=virtual&&linux/#showFailuresLink

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+31230_gradle48_jdk11+matrix-java-feature-branch/5/ES_BUILD_JAVA=java11,ES_RUNTIME_JAVA=java11,nodes=virtual&&linux/#showFailuresLink

java.lang.AssertionError: 
Expected: "6"
     but: was "Index 6 out of bounds for length 5"
	at __randomizedtesting.SeedInfo.seed([AF4A4AFC8D181DA4:D77E913660E3067D]:0)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:956)
	at org.junit.Assert.assertThat(Assert.java:923)
	at org.elasticsearch.painless.ArrayLikeObjectTestCase.expectOutOfBounds(ArrayLikeObjectTestCase.java:88)
	at org.elasticsearch.painless.ArrayLikeObjectTestCase.arrayLoadStoreTestCase(ArrayLikeObjectTestCase.java:55)
	at org.elasticsearch.painless.ArrayLikeObjectTestCase.testLongsInDef(ArrayLikeObjectTestCase.java:98)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1713)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:907)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:943)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:957)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:49)
	at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
	at org.apache.lucene.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:48)
	at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
	at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
	at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:916)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:802)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:852)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:863)
	at org.apache.lucene.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:45)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:41)
	at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
	at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
	at org.apache.lucene.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:47)
	at org.apache.lucene.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:64)
	at org.apache.lucene.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:54)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
	at java.base/java.lang.Thread.run(Thread.java:832)
	Suppressed: java.lang.ArrayIndexOutOfBoundsException: Index 6 out of bounds for length 5
		at java.base/java.lang.invoke.MethodHandleImpl$ArrayAccessor.getElementJ(MethodHandleImpl.java:168)
		at java.base/java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:707)
		at org.elasticsearch.painless.DefBootstrap$PIC.fallback(DefBootstrap.java:211)
		at org.elasticsearch.painless.PainlessScript$Script.execute(def x = new long[5]; return x[ 6]:30)
		at org.elasticsearch.painless.ScriptImpl.run(ScriptImpl.java:105)
		at org.elasticsearch.painless.ScriptTestCase.exec(ScriptTestCase.java:106)
		at org.elasticsearch.painless.ScriptTestCase.exec(ScriptTestCase.java:86)
		at org.elasticsearch.painless.ArrayLikeObjectTestCase.lambda$expectOutOfBounds$0(ArrayLikeObjectTestCase.java:81)
		at org.elasticsearch.painless.ScriptTestCase.expectScriptThrows(ScriptTestCase.java:136)
		at org.elasticsearch.painless.ScriptTestCase.expectScriptThrows(ScriptTestCase.java:129)
		at org.elasticsearch.painless.ArrayLikeObjectTestCase.expectOutOfBounds(ArrayLikeObjectTestCase.java:80)
		... 38 more

[elasticmachine]

Pinging @elastic/es-core-infra

[bleskes]

@atorok is this something you're looking at or would you like @jdconrad to have a look?

[alpar-t]

I haven't looked at it yet, my focus is to map all JDK11 related issues first by muting anything that fails and then picking them up. I'm find either way, let's just make sure to ping here if we start working on it to make sure we don't do it at the same time.

[s1monw]

I agree with @bleskes I wonder if @jdconrad can help here

[jdconrad]

Just got back from vacation. Will take a look soon.

[jdconrad]

@atorok Looks like Java 11 has changed the message for an ArrayIndexOutOfBoundsException from just the out of bound 6 index to Index 6 out of bounds for length 5 so the matcher for the test needs to be changed. Have you added a constant to test for Java 11 minimum already like we have for 8 and 9?

If so I believe it should be as simple as replacing the existing outOfBoundsExceptionMessageMatcher method in ArrayTests for Painless with the following:

    @Override
    protected Matcher<String> outOfBoundsExceptionMessageMatcher(int index, int size) {
        if (Constants.JRE_IS_MINIMUM_JAVA11) {
            return equalTo("Index " + Integer.toString(index) + " out of bounds for length " + Integer.toString(size));
        }
        return equalTo(Integer.toString(index));
    }

Let me know if that works or I can be of help in anyway. Thanks for catching this bug!

[jasontedor]

@jdconrad The constants come from Lucene; in this case we can use

JavaVersion.current().compareTo(JavaVersion.parse("11"))

which uses our own code (from org.elasticsearch.bootstrap.JavaVersion).

[rjernst]

Have you added a constant to test for Java 11 minimum already like we have for 8 and 9?

The Constants class you are referring to is in Lucene, and hasn't been updated. Unfortunately the parsed major/minor that Constants contains is private to the class, so you would need to parse the java.specification.version in this test yourself to check for java 11.

[rjernst]

Or even better use JavaVersion that Jason mentioned. Sorry my comment got delayed in sending.

[jdconrad]

Ah, apologies didn't realize that was from Lucene.