Skip to content

TermsSetQueryBuilder#doEquals is incorrect #29620

@twilson-palantir

Description

@twilson-palantir

Currently written as

    protected boolean doEquals(TermsSetQueryBuilder other) {
        return Objects.equals(fieldName, this.fieldName) && Objects.equals(values, this.values) &&
                Objects.equals(minimumShouldMatchField, this.minimumShouldMatchField) &&
                Objects.equals(minimumShouldMatchScript, this.minimumShouldMatchScript);
    }

should be

    protected boolean doEquals(TermsSetQueryBuilder other) {
        return Objects.equals(fieldName, other.fieldName) && Objects.equals(values, other.values) &&
                Objects.equals(minimumShouldMatchField, other.minimumShouldMatchField) &&
                Objects.equals(minimumShouldMatchScript, other.minimumShouldMatchScript);
    }

Metadata

Metadata

Assignees

No one assigned

    Labels

    :Search/SearchSearch-related issues that do not fall into other categories>bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions