[?] REST : Split `RestUpgradeAction` into `RestUpgradeAction` and `RestUpgradeStatusAction`

[olcbean]

Currently RestUpgradeAction handles two distinct actions, each one having a separate request, response and transport level action.
Should these actions be separated into two dedicated rest actions?

rest endpoint	request	transport action	response
GET _upgrade	UpgradeStatusRequest	upgradeStatus	UpgradeStatusResponse
POST _upgrade	UpgradeRequest	upgrade	UpgradeResponse

[jasontedor]

Yes!

[milan15]

@olcbean @jasontedor am beginner here, got excited, went through code and tried to understand proposed changes (and underlying code) and below are the steps that i thought will need to be taken.

1. Split RestUpgradeAction class, create new class RestUpgradeStatusAction. Move handleGet code to new class and made other changes accordingly.
2. ActionModule#initRestHandlers -Add (or register) handler with accept() call for new class RestUpgradeStatusAction.

Planning to play with this and see, let me know if i am missing something obvious here and i am requesting if i can take this up?

[olcbean]

@milan15 thanks for your interest!
Sounds good to me - that would have been my initial steps too 👍

[milan15]

@olcbean i did above changes and tested rest layer and it gave below error. but when i try to reproduce it using given command, don't receive error anymore. any pointers here? let me know if you want me to open PR to see my changes.

2> REPRODUCE WITH: ./gradlew :distribution:archives:integ-test-zip:integTestRunner -Dtests.seed=A5D9DA2EB4385EE9 -Dtests.class=org.elasticsearch.test.rest.IntegTestZipClientYamlTestSuiteIT -Dtests.method="test {p0=index/20_optype/Optype}" -Dtests.security.manager=true -Dtests.locale=is -Dtests.timezone=America/St_Kitts
ERROR 0.44s | IntegTestZipClientYamlTestSuiteIT.test {p0=index/20_optype/Optype} <<< FAILURES!
Throwable #1: java.lang.Exception: Test abandoned because suite timeout was reached.
at __randomizedtesting.SeedInfo.seed([A5D9DA2EB4385EE9]:0)
2> mar. 16, 2018 7:06:55 F.H. com.carrotsearch.randomizedtesting.ThreadLeakControl checkThreadLeaks
2> WARNING: Will linger awaiting termination of 11 leaked thread(s).
1> [2018-03-16T07:06:55,713][INFO ][o.e.t.r.IntegTestZipClientYamlTestSuiteIT] [test {p0=index/20_optype/Optype}]: after test
2> REPRODUCE WITH: ./gradlew :distribution:archives:integ-test-zip:integTestRunner -Dtests.seed=A5D9DA2EB4385EE9 -Dtests.class=org.elasticsearch.test.rest.IntegTestZipClientYamlTestSuiteIT -Dtests.security.manager=true -Dtests.locale=en-US -Dtests.timezone=America/Los_Angeles
2> NOTE: test params are: codec=Lucene70, sim=RandomSimilarity(queryNorm=true): {}, locale=is, timezone=America/St_Kitts
2> NOTE: Mac OS X 10.13.2 x86_64/Oracle Corporation 9.0.4 (64-bit)/cpus=4,threads=1,free=342897088,total=536870912
2> NOTE: All tests run in this JVM: [IntegTestZipClientYamlTestSuiteIT]
ERROR 0.00s | IntegTestZipClientYamlTestSuiteIT (suite) <<< FAILURES!
Throwable #1: java.lang.Exception: Suite timeout exceeded (>= 1200000 msec).
at __randomizedtesting.SeedInfo.seed([A5D9DA2EB4385EE9]:0)
Completed [1/1] in 1201.31s, 894 tests, 2 errors, 16 skipped <<< FAILURES!

[olcbean]

@milan15 Thanks!
AFAICS you ran into a timeout ( Suite timeout exceeded ) in the index rest api test for optype. I do not think that it is related to the changes you did for this issue ;)
Maybe unrelated question, but are you running on Windows? ( @nik9000 : do you have an idea why the timeout is reached ? )

Dtests.class=org.elasticsearch.test.rest.IntegTestZipClientYamlTestSuiteIT -Dtests.method="test {p0=index/20_optype/Optype}"

Test abandoned because suite timeout was reached.

Throwable #1: java.lang.Exception: Suite timeout exceeded (>= 1200000 msec).

If you want you can open a PR ( even if it is still "work-in-progress" ), then a member can trigger a CI. This could help to determine if there is a problem in a test, in the rest tests or it is an environmental issue.

Sorry I could not be of more help

[milan15]

@olcbean @nik9000 Thanks! i thought the same and no i am using macOS. and i am too wondering if it's an environment issue as when i ran multiple times it fails only sometimes with same error.

will open a PR so code can also be looked at.

[olcbean]

BTW I ran your PR locally on a linux host and it passed all tests!