transportclient BulkProcessor lost header !!! threadPool().getThreadContext().getHeader

[hexian55]

Describe the feature:

BulkProcessor lost threadPool().getThreadContext().getHeader
Elasticsearch version (bin/elasticsearch --version):
5.5x
Plugins installed: []

JVM version (java -version):

OS version (uname -a if on a Unix-like system):
linux macos
Description of the problem including expected versus actual behavior:

Steps to reproduce:

Please include a minimal but complete recreation of the problem, including
(e.g.) index creation, mappings, settings, query etc. The easier you make for
us to reproduce it, the more likely that somebody will take the time to look at it.

Provide logs (if relevant):

when I use transport client, put header to threadpool.threadContext.header，
but sometime ,the header lost.
I'm cp BulkProcessor.java BulkRequestHandler.java
and add log to print threadpool.threadContext.header, it's lost by sometime.

client code:
client.threadPool().getThreadContext().putHeader("Authorization", token);

BulkRequestHandler update code:

output:

[colings86]

@javanna are you able to have a look at this?

[colings86]

Could you explain a bit more about what you are trying to do? Why are you trying to set Authorization headers in this way? If you are trying to authenticate with the XPack Security plugin then this can be done by following the steps in https://www.elastic.co/guide/en/x-pack/current/java-clients.html. The threadpool is almost certainly not going to be the right place to be setting these headers.

[hexian55]

I have found a way to fix it.
I use myself authority plugin.
Add authentication in transportt client header and http header.
but in BulkProcessor, when add request, eg: bulkProcessor.add(request),

private synchronized void internalAdd(DocWriteRequest request, @nullable Object payload) {
ensureOpen();
bulkRequest.add(request, payload);
executeIfNeeded();
}
if executeIfNeeded(), then execute Immediately in this thread.
but if flushInterval To meet the conditions, then execute Immediately in other thread .
so, this header is lost in other thread.

[colings86]

Glad you have found a fix but do note that this is not a supported way of adding headers so this could well break in subsequent versions

[hexian55]

I want to fix this code, can reopen this issues?
but if well break in subsequent versions, Can there be other ways to replace it?
Or now i have other better way to do it？

[hexian55]

@OverRide
public void execute(BulkRequest bulkRequest, long executionId, Map<String, String> headers) {
if (client.threadPool().getThreadContext().getHeaders() == null && headers != null) {
client.threadPool().getThreadContext().putHeader(headers);
}....
I want to add header para in this method.
it's will fix this bug, Do you have a better suggestion?

[hexian55]

@colings86

[colings86]

I have found a way to fix it.

I took this as you had solved your problem and your issue was fixed which is why I closed the issue. However, we do reserve this Github issue list only for bug reports and feature requests. It is clear now that this is not a bug in Elasticsearch but rather a question about a bug in your application code. Questions like this should normally be asked in the Elasticsearch forum. Could you create a topic there to discuss this further? I am not familiar enough with this aspect of the codebase to know what the right solution is here

[hexian55]

but I think this is es bug, because this header lost in org.elasticsearch.action.bulk.BulkProcessor.

[colings86]

@jaymode @javanna is the ThreadContext supposed to be used in this manner to set and get headers and therefore not being able to get the header from the thread context is a bug?