%JAVA_HOME% resiliency on Windows

[Mpdreamz]

Right now we break if:

• JAVA_HOME end with a trailing slash
• Path is already quoted in the variable.

We should either attempt to fix, or detect and exit with a more appropriate message explaining the issue and the fix.

cc @elastic/microsoft

[olcbean]

Hi @Mpdreamz,
I noticed this issue has been open for a while, and since it was a quick fix I just put together a solution in PR #27077. Could you please take a look? Thanks!

[olcbean]

I quickly tested with JAVA_HOME ending with / or \ and the service is correctly installed and started.

@Mpdreamz what issue did you encounter with /?

[andyb-elastic]

Here's another path that breaks it. It splits the path after the parens - the "and" in the output is the "and" from the path after "(parens)". Sorry for the screenshot, virtualbox copy and paste isn't working for me today

[olcbean]

Hm.... there was some work done in this area ( the problem here is ) ) #26916 and #27012
@andyb-elastic which version are you running with ?

[andyb-elastic]

That was on master at 2d1d650