Remove threadpool type cached setting from documentation?

[ppf2]

We don't recommend changing the size of the thread pools, and certainly not recommend setting them to unbounded. Seems like documenting the configuration to modify our thread pools to cached without sufficient warnings will do more harm than good.

[jasontedor]

I think that we should go further than merely removing it from the documentation, but actually forbidding any thread pool other than the generic thread pool of being of type "cached". The generic thread pool should remain as "cached" because operations that are submitted to this thread pool can not block nor be rejected; we remain very careful about which operations are submitted to this thread pool. I've opened #14336 to address.

[bleskes]

I wonder if we should allow to configure the thread pools types at all these days. Might be the simplest to just remove the option and fix the defaults we have now.

On 28 okt. 2015 3:22 PM +0100, Jason Tedornotifications@github.com, wrote:

I think that we should go further than merely removing it from the documentation, but actually forbidding any thread pool other than the generic thread pool of being of type "cached". The generic thread pool should remain as "cached" because operations that are submitted to this thread pool can not block nor be rejected; we remain very careful about which operations are submitted to this thread pool. I've opened#14336(#14336 address.

—
Reply to this email directly orview it on GitHub(#14294 (comment)).

[jasontedor]

I've added the discuss label to open up if we want to take this further than merely forbidding the cached thread pool type and actually forbidding changing any thread pool type.

[jpountz]

+1 to not allow to configure threadpool types at all

[s1monw]

+1

[jasontedor]

I've closed #14336 in favor of #14367 which takes the original pull request further by forbidding the changing of the thread pool type for any thread pool.