Skip to content

Commit 8f5e32a

Browse files
authored
[Data-Frame] make the config be strictly parsed on _preview (#39713)
* [Data-Frame] make the config be strictly parsed on _preview * adding test to verify strictly parsing * adjusting test after master merge
1 parent c94ebef commit 8f5e32a

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/dataframe/action/PreviewDataFrameTransformAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ public static Request fromXContent(final XContentParser parser) throws IOExcepti
6565
.createParser(parser.getXContentRegistry(),
6666
LoggingDeprecationHandler.INSTANCE,
6767
BytesReference.bytes(xContentBuilder).streamInput())) {
68-
return new Request(DataFrameTransformConfig.fromXContent(newParser, "transform-preview", true));
68+
return new Request(DataFrameTransformConfig.fromXContent(newParser, "transform-preview", false));
6969
}
7070
}
7171

x-pack/plugin/src/test/resources/rest-api-spec/test/data_frame/preview_transforms.yml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -88,3 +88,17 @@ setup:
8888
- match: { preview.2.airline: foo }
8989
- match: { preview.2.by-hour: "2017-02-49 01" }
9090
- match: { preview.2.avg_response: 42.0 }
91+
92+
---
93+
"Test preview transform with invalid config":
94+
- do:
95+
catch: /\[data_frame_terms_group\] unknown field \[not_a_terms_param\]/
96+
data_frame.preview_data_frame_transform:
97+
body: >
98+
{
99+
"source": "airline-data",
100+
"pivot": {
101+
"group_by": {"airline": {"terms": {"not_a_terms_param": "airline"}}},
102+
"aggs": {"avg_response": {"avg": {"field": "responsetime"}}}
103+
}
104+
}

0 commit comments

Comments
 (0)