Skip to content

[Data-Frame] make the config be strictly parsed on _preview #39713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 9, 2019
Merged

[Data-Frame] make the config be strictly parsed on _preview #39713

merged 5 commits into from
Mar 9, 2019

Conversation

@benwtrent
Copy link
Member

@benwtrent benwtrent commented Mar 5, 2019

Simple change, it should have been strictly parsed from the get go....

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 5, 2019

Pinging @elastic/ml-core

dimitris-athanasiou
dimitris-athanasiou approved these changes Mar 5, 2019
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hendrikmuhs
Copy link

hendrikmuhs commented Mar 5, 2019

may I play devils advocate?

If we missed this in the 1st place it means we lack a test.

@jasontedor jasontedor mentioned this pull request Mar 6, 2019
Closed
@benwtrent
Copy link
Member Author

benwtrent commented Mar 8, 2019

@elasticmachine
run elasticsearch-ci/1
run elasticsearch-ci/2
run elasticsearch-ci/bwc
run elasticsearch-ci/default-distro

@benwtrent
Copy link
Member Author

benwtrent commented Mar 8, 2019

run elasticsearch-ci/bwc

hendrikmuhs
hendrikmuhs approved these changes Mar 8, 2019
View reviewed changes
Copy link

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent
Copy link
Member Author

benwtrent commented Mar 8, 2019

run elasticsearch-ci/bwc

2 similar comments
@benwtrent
Copy link
Member Author

benwtrent commented Mar 8, 2019

run elasticsearch-ci/bwc

@benwtrent
Copy link
Member Author

benwtrent commented Mar 8, 2019

run elasticsearch-ci/bwc

@benwtrent
Copy link
Member Author

benwtrent commented Mar 8, 2019

run elasticsearch-ci/bwc

@benwtrent benwtrent merged commit 8f5e32a into elastic:master Mar 9, 2019
@benwtrent benwtrent deleted the feature/data-frame-make-preview-strictly-parse-config branch March 9, 2019 04:11
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Mar 9, 2019
@benwtrent
[Data-Frame] make the config be strictly parsed on _preview (elastic#…
0d925c6 
…39713)

* [Data-Frame] make the config be strictly parsed on _preview

* adding test to verify strictly parsing

* adjusting test after master merge
benwtrent added a commit that referenced this pull request Mar 9, 2019
@benwtrent
[Data-Frame] make the config be strictly parsed on _preview (#39713) (#…
6c6549f 
…39873)

* [Data-Frame] make the config be strictly parsed on _preview

* adding test to verify strictly parsing

* adjusting test after master merge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimitris-athanasiou dimitris-athanasiou dimitris-athanasiou approved these changes

+1 more reviewer

@hendrikmuhs hendrikmuhs hendrikmuhs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

:ml Machine learning >non-issue v7.2.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@benwtrent @elasticmachine @hendrikmuhs @dimitris-athanasiou @jakelandis