Reduce visibility in sequence number services

This commit reduces the visibility of certain fields and methods in the
local and global checkpoint services.

Author: jasontedor

core/src/main/java/org/elasticsearch/index/seqno/GlobalCheckpointService.java

@@ -69,7 +69,7 @@ public class GlobalCheckpointService extends AbstractIndexShardComponent {
 
     private long globalCheckpoint;
 
-    public GlobalCheckpointService(final ShardId shardId, final IndexSettings indexSettings, final long globalCheckpoint) {
+    GlobalCheckpointService(final ShardId shardId, final IndexSettings indexSettings, final long globalCheckpoint) {
         super(shardId, indexSettings);
         activeLocalCheckpoints = new ObjectLongHashMap<>(1 + indexSettings.getNumberOfReplicas());
         inSyncLocalCheckpoints = new ObjectLongHashMap<>(indexSettings.getNumberOfReplicas());
@@ -124,7 +124,7 @@ private boolean updateLocalCheckpointInMap(String allocationId, long localCheckp
      * @return true if the checkpoint has been updated or if it can not be updated since one of the local checkpoints
      * of one of the active allocations is not known.
      */
-    synchronized public boolean updateCheckpointOnPrimary() {
+    synchronized boolean updateCheckpointOnPrimary() {
         long minCheckpoint = Long.MAX_VALUE;
         if (activeLocalCheckpoints.isEmpty() && inSyncLocalCheckpoints.isEmpty()) {
             return false;
@@ -164,7 +164,7 @@ synchronized public long getCheckpoint() {
     /**
      * updates the global checkpoint on a replica shard (after it has been updated by the primary).
      */
-    synchronized public void updateCheckpointOnReplica(long globalCheckpoint) {
+    synchronized void updateCheckpointOnReplica(long globalCheckpoint) {
         if (this.globalCheckpoint <= globalCheckpoint) {
             this.globalCheckpoint = globalCheckpoint;
             logger.trace("global checkpoint updated from primary to [{}]", globalCheckpoint);

core/src/main/java/org/elasticsearch/index/seqno/LocalCheckpointService.java

@@ -45,16 +45,16 @@ public class LocalCheckpointService extends AbstractIndexShardComponent {
      * which marks the seqNo the fist bit in the first array corresponds to.
      */
     final LinkedList<FixedBitSet> processedSeqNo;
-    final int bitArraysSize;
+    private final int bitArraysSize;
     long firstProcessedSeqNo;
 
     /** the current local checkpoint, i.e., all seqNo lower (&lt;=) than this number have been completed */
     volatile long checkpoint;
 
     /** the next available seqNo - used for seqNo generation */
-    volatile long nextSeqNo;
+    private volatile long nextSeqNo;
 
-    public LocalCheckpointService(final ShardId shardId, final IndexSettings indexSettings, final long maxSeqNo, final long checkpoint) {
+    LocalCheckpointService(final ShardId shardId, final IndexSettings indexSettings, final long maxSeqNo, final long checkpoint) {
         super(shardId, indexSettings);
         bitArraysSize = SETTINGS_BIT_ARRAYS_SIZE.get(indexSettings.getSettings());
         processedSeqNo = new LinkedList<>();
@@ -66,14 +66,14 @@ public LocalCheckpointService(final ShardId shardId, final IndexSettings indexSe
     /**
      * issue the next sequence number
      **/
-    public synchronized long generateSeqNo() {
+    synchronized long generateSeqNo() {
         return nextSeqNo++;
     }
 
     /**
      * marks the processing of the given seqNo have been completed
      **/
-    public synchronized void markSeqNoAsCompleted(long seqNo) {
+    synchronized void markSeqNoAsCompleted(long seqNo) {
         // make sure we track highest seen seqNo
         if (seqNo >= nextSeqNo) {
             nextSeqNo = seqNo + 1;
@@ -96,7 +96,7 @@ public long getCheckpoint() {
     }
 
     /** gets the maximum seqno seen so far */
-    public long getMaxSeqNo() {
+    long getMaxSeqNo() {
         return nextSeqNo - 1;
     }