Remove superfluous local checkpoint constructor

This commit removes a constructor from the local checkpoint service that
was only used in tests.

Author: jasontedor

core/src/main/java/org/elasticsearch/index/seqno/LocalCheckpointService.java

@@ -54,10 +54,6 @@ public class LocalCheckpointService extends AbstractIndexShardComponent {
     /** the next available seqNo - used for seqNo generation */
     volatile long nextSeqNo;
 
-    public LocalCheckpointService(final ShardId shardId, final IndexSettings indexSettings) {
-        this(shardId, indexSettings, SequenceNumbersService.NO_OPS_PERFORMED, SequenceNumbersService.NO_OPS_PERFORMED);
-    }
-
     public LocalCheckpointService(final ShardId shardId, final IndexSettings indexSettings, final long maxSeqNo, final long checkpoint) {
         super(shardId, indexSettings);
         bitArraysSize = SETTINGS_BIT_ARRAYS_SIZE.get(indexSettings.getSettings());

core/src/test/java/org/elasticsearch/index/seqno/LocalCheckpointServiceTests.java

@@ -53,12 +53,13 @@ public void setUp() throws Exception {
 
     private LocalCheckpointService getCheckpointService() {
         return new LocalCheckpointService(
-            new ShardId("test", "_na_", 0),
-            IndexSettingsModule.newIndexSettings("test",
-                Settings.builder()
-                    .put(LocalCheckpointService.SETTINGS_BIT_ARRAYS_SIZE.getKey(), SMALL_CHUNK_SIZE)
-                    .build()
-            ));
+                new ShardId("test", "_na_", 0),
+                IndexSettingsModule.newIndexSettings("test",
+                        Settings.builder()
+                                .put(LocalCheckpointService.SETTINGS_BIT_ARRAYS_SIZE.getKey(), SMALL_CHUNK_SIZE)
+                                .build()),
+                SequenceNumbersService.NO_OPS_PERFORMED,
+                SequenceNumbersService.NO_OPS_PERFORMED);
     }
 
     public void testSimplePrimary() {