Force flush in FullClusterRestartIT#testRecovery (#46956)

If peer recovery happens after indexing, and indexing flushes some shard
at the end, then the explicit flush in the test will be a noop. Then
replicas will have some uncommitted translog , which is transferred in
peer recovery, although all of these operations are in the commit
already. If that replica becomes primary (after we restarted the
cluster), it will have translog to replay and the test will fail.

Another issue in this test is that synced_flush is not a replication
action, then the global checkpoint on replicas might be not up to date.
We need to either wait for the global checkpoint to be synced or call a
replication action to sync it.

Closes #46712

Author: dnhatn

qa/full-cluster-restart/src/test/java/org/elasticsearch/upgrades/FullClusterRestartIT.java

@@ -674,6 +674,8 @@ public void testRecovery() throws Exception {
             ensureGreen(index);
             // Recovering a synced-flush index from 5.x to 6.x might be subtle as a 5.x index commit does not have all 6.x commit tags.
             if (randomBoolean()) {
+                // needs to call a replication action to sync the global checkpoint from primaries to replication.
+                assertOK(client().performRequest(new Request("POST", "/" + index + "/_refresh")));
                 // We have to spin synced-flush requests here because we fire the global checkpoint sync for the last write operation.
                 // A synced-flush request considers the global checkpoint sync as an going operation because it acquires a shard permit.
                 assertBusy(() -> {
@@ -688,7 +690,10 @@ public void testRecovery() throws Exception {
                 });
             } else {
                 // Explicitly flush so we're sure to have a bunch of documents in the Lucene index
-                assertOK(client().performRequest(new Request("POST", "/_flush")));
+                Request flushRequest = new Request("POST", "/" + index + "/_flush");
+                flushRequest.addParameter("force", "true");
+                flushRequest.addParameter("wait_if_ongoing", "true");
+                assertOK(client().performRequest(flushRequest));
             }
             if (shouldHaveTranslog) {
                 // Update a few documents so we are sure to have a translog