Skip to content

Conversation

@bpintea
Copy link
Collaborator

@bpintea bpintea commented Oct 11, 2022

This adds support for authenticating using API Keys.

The DSN editor has been updated to take a new "API Key" field. This field is enabled iif no Username and Password are provided. The field is stored in the DSN string and then used in every request for respective configured connection.

This adds support for authenticating using API Keys.

The DSN editor has been updated to take a new "API Key" field. This
field is enabled iif no Username and Password are provided.
The field is stored in the DSN string and then used in every request for
respective configured connection.
@bpintea bpintea added >feature Applicable to PRs adding new functionality v8.6.0 labels Oct 11, 2022
Add integration testing for the API Key usage.
Correct tooltip wording.
Copy link
Collaborator

@edsavage edsavage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checked the C code changes and they LGTM

Copy link

@stevejgordon stevejgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# changes LGTM

@bpintea bpintea merged commit 3aaf735 into elastic:main Oct 24, 2022
@bpintea bpintea deleted the feat/api_key branch October 24, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>feature Applicable to PRs adding new functionality v8.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants