Fix SQLDescribeCol numeric attribute param handling #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last parameter of SQLDescribeCol(), the "NumericAttributePtr" is an out paramter that should always point to a SQLLEN value (for both x64 and x32 builds), despite this value being assigned different width values. The x32 API definition uses a "void *" that would allow passing pointers to various width integers, but the spec does require an SQLLEN and other drivers and apps alligned to it. Some apps seem however to not cast down to the width corresponding to the various attributes, which can lead to incorrect behaviour. The driver now scales up all values to an SQLLEN.
Add unit tests for the SQLColAttribute() in connection with various types of attributes queried. Fix the value returned for SQL_DESC_NUM_PREC_RADIX attribute.
Replace explicit bit setting of attr value to be passed in to tested function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last parameter of SQLDescribeCol(), the "NumericAttributePtr" is an
out parameter that should always point to a SQLLEN value (for both x64
and x32 builds), despite this value being assigned different width
values.
The x32 API definition uses a "void *" that would allow passing pointers
to various width integers, but the spec does require an SQLLEN and other
drivers and apps aligned to it. Some apps seem however to not cast down
to the width corresponding to the various attributes, which can lead to
incorrect behavior. The driver now scales up all values to an SQLLEN.
Also, returning of the SQL_DESC_NUM_PREC_RADIX attribute is
corrected.